Re: [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification

Also, I just applied the attached patch, to kill a warning:

drivers/scsi/sata_mv.c:471: warning: 'mv_dump_mem' defined but not used

	Jeff

diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -467,9 +467,9 @@ static void mv_stop_dma(struct ata_port 
 	}
 }
 
+#ifdef ATA_DEBUG
 static void mv_dump_mem(void __iomem *start, unsigned bytes)
 {
-#ifdef ATA_DEBUG
 	int b, w;
 	for (b = 0; b < bytes; ) {
 		DPRINTK("%p: ", start + b);
@@ -479,8 +479,9 @@ static void mv_dump_mem(void __iomem *st
 		}
 		printk("\n");
 	}
-#endif
 }
+#endif
+
 static void mv_dump_pci_cfg(struct pci_dev *pdev, unsigned bytes)
 {
 #ifdef ATA_DEBUG

---

• References:
  • [PATCH 2.6.14-rc2 0/2] libata: Marvell SATA support (v0.23-0.24)
    • From: Brett Russ <[email protected]>
  • [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification
    • From: Brett Russ <[email protected]>
  • Re: [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [PATCH] Documentation: ksymoops should no longer be used to decode Oops messages
• Next by Date: Re: [swsusp] separate snapshot functionality to separate file
• Previous by thread: Re: [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification
• Next by thread: Re: [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]