Re: [PATCH] i386: move apic init in init_IRQs

"Maciej W. Rozycki" <[email protected]> writes:

> On Tue, 4 Oct 2005, Eric W. Biederman wrote:
>
>> -	if (enable_local_apic < 0)
>> -		clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
>
>  I think this should stay.

lapic_disable() already does this.  I am just testing the results.

>> +	if (enable_local_apic < 0) {
>> +		printk(KERN_INFO "Apic disabled\n");
>
>  Capitalisation. ;-)
>
>  Otherwise it seems reasonable -- provided it works for you. ;-)

So what should the capitalization be? "APIC disabled\n" ?

Sorry.

Eric


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] i386: move apic init in init_IRQs
    • From: "Maciej W. Rozycki" <[email protected]>

• References:
  • [PATCH] i386: move apic init in init_IRQs
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] i386: move apic init in init_IRQs
    • From: "Maciej W. Rozycki" <[email protected]>

• Prev by Date: Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel
• Next by Date: error during compiling kernel 2.6.10 on FC3
• Previous by thread: Re: [PATCH] i386: move apic init in init_IRQs
• Next by thread: Re: [PATCH] i386: move apic init in init_IRQs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]