Re: [PATCH] release_resource() check for NULL resource

On Sun, 2 Oct 2005 18:03:18 +0100 Ben Dooks wrote:

> If release_resource() is passed a NULL resource
> the kernel will OOPS.

does this actually happen?  you are fixing a real oops?
if so, what driver caused it?

btw, please use diff -p also (as in Documentation/SubmittingPatches)


> Signed-off-by: Ben Dooks <[email protected]>
> 
> diff -urN -X ../dontdiff linux-2.6.14-rc3/kernel/resource.c linux-2.6.14-rc3-bjd1/kernel/resource.c
> --- linux-2.6.14-rc3/kernel/resource.c	2005-10-02 12:58:03.000000000 +0100
> +++ linux-2.6.14-rc3-bjd1/kernel/resource.c	2005-10-02 17:58:09.000000000 +0100
> @@ -181,6 +181,9 @@
>  {
>  	struct resource *tmp, **p;
>  
> +	if (!old)
> +		return 0;
> +
>  	p = &old->parent->child;
>  	for (;;) {
>  		tmp = *p;
> 


---
~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] release_resource() check for NULL resource
    • From: Ben Dooks <[email protected]>

• References:
  • [PATCH] release_resource() check for NULL resource
    • From: Ben Dooks <[email protected]>

• Prev by Date: Re: [2.6.14-rc4/x86_64]: Kernel BUG at mm/slab.c:1876
• Next by Date: Re: A possible idea for Linux: Save running programs to disk
• Previous by thread: [PATCH] release_resource() check for NULL resource
• Next by thread: Re: [PATCH] release_resource() check for NULL resource
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]