Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio

On Sat, 1 Oct 2005, Harald Welte wrote:
> 
> please find the patch below.  It compiles, but I didn't yet have the
> time to verify it makes the bug disappear and the async urb delivery is
> still working.

No, you can't re-use "check_kill_permissions()" like this, even though I 
do understand the appeal.

The generic kill permissions check things like the current session, and 
whether the caller has extra permissions, neither of which is sensible in 
the context of "group_send_sig_info_as_uid()". So you do need to write out 
the uid/euid checks separately, and have a different function for this 
thing.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Harald Welte <[email protected]>
  • Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Linus Torvalds <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Sergey Vlasov <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Linus Torvalds <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Sergey Vlasov <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Linus Torvalds <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Harald Welte <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Linus Torvalds <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Chris Wright <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Linus Torvalds <[email protected]>
  • Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
    • From: Harald Welte <[email protected]>

• Prev by Date: Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel
• Next by Date: Re: I request inclusion of SAS Transport Layer and AIC-94xx into the kernel
• Previous by thread: Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
• Next by thread: PID reuse safety for userspace apps (Re: [linux-usb-devel] Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]