Re: [PATCH] Fix IXP4xx MTD driver no cast warning

[Jörn Engel <joern@wohnheim.fh-wedel.de>]

On Thu, 29 September 2005 14:20:55 -0700, Deepak Saxena wrote:
> On Sep 29 2005, at 21:52, Russell King was caught saying:
> > On Thu, Sep 29, 2005 at 12:52:05PM -0700, Deepak Saxena wrote:
> > > Fix following warning:
> > > 
> > > drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe':
> > > drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from
> > > pointer without a cast
> > > 
> > > Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
> > > 
> > > diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
> > > --- a/drivers/mtd/maps/ixp4xx.c
> > > +++ b/drivers/mtd/maps/ixp4xx.c
> > > @@ -196,7 +196,7 @@ static int ixp4xx_flash_probe(struct dev
> > >  		goto Error;
> > >  	}
> > >  
> > > -	info->map.map_priv_1 = ioremap(dev->resource->start,
> > > +	info->map.map_priv_1 = (unsigned long)ioremap(dev->resource->start,
> > 
> > Shouldn't this be using info->map.virt instead of the old map.map_priv_1 ?
> 
> I think when I wrote this, having a !0 value in map->virt would cause the mtd
> core to assume that the map driver supported point()ing and direct copy
> of data.  Looking at the mtd code it looks like this assumption might
> have gone away...will change code.

A check on this field is still used in cfi_intelext_point(), but you
can disable the point stuff by setting map->phys to NO_XIP - as you
already do.

Jörn

-- 
All art is but imitation of nature.
-- Lucius Annaeus Seneca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/