Re: [patch 1/1] cpufreq_conservative: invert meaning of 'ignore_nice'

[Dave Jones <davej@redhat.com>]

On Thu, Sep 29, 2005 at 01:46:33PM +0200, Blaisorblade wrote:
 > On Thursday 29 September 2005 10:44, Alexander Clouter wrote:
 > > The use of the 'ignore_nice' sysfs file is confusing to anyone using.  This
 > > patch makes it so when you now set it to the default value of 1, process
 > > nice time is also ignored in the cpu 'busyness' calculation.
 > 
 > > Prior to this patch to set it to '1' to make process nice time count...even
 > > confused me :)
 > 
 > > WARNING: this obvious breaks any userland tools that expect things to be
 > > the other way round.  This patch clears up the confusion but should go in
 > > ASAP as at the moment it seems very few tools even make use of this
 > > functionality; all I could find was a Gentoo Wiki entry.
 > 
 > My suggestion on this is to rename the flag too, as ignore_nice_load (or 
 > ignore_nice_tasks, choose your way). Don't forget to do it in docs too.
 > 
 > So userspace tools will error out rather than do the reverse of what they were 
 > doing, and the user will fix the thing according to the (new) docs.

Agreed. If we change this, we change it completely.
Stefan already mentioned his app will break, and we typically don't
find out about widespread breakage until after we ship a release.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/