On Thu, Sep 29, 2005 at 09:02:29AM -0700, Suzanne Wood wrote:
>
> The exchange below suggests that it is equally important
> to have the rcu_dereference() in __in_dev_get(), so the
> idea of the only difference between in_dev_get and
> __in_dev_get being the refcnt may be accepted.
With __in_dev_get() it's the caller's responsibility to ensure
that RCU works correctly. Therefore if any rcu_dereference is
needed it should be done by the caller.
Some callers of __in_dev_get() don't need rcu_dereference at all
because they're protected by the rtnl.
BTW, could you please move the rcu_dereference in in_dev_get()
into the if clause? The barrier is not needed when ip_ptr is
NULL.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |