Re: [PATCH 4/9] defrag helper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+void assign_bit(int bit_nr, unsigned long* map, int value)


Maybe:
static inline void assign_bit(int bit_nr, unsigned long* map, int value)

it's short enough

OK.  It looks like I'll be sending these again based on the feedback I got,
I'll inline that in the next version.  I'd think with it being static that
the compiler would be smart enough to inline it anyway though.


 +static struct page *
+fallback_alloc(int alloctype, struct zone *zone, unsigned int order)
+{
+       /* Stub out for seperate review, NULL equates to no fallback*/
+       return NULL;
+
+}


Maybe "static inline" too.

Except this is only a placeholder for the next patch, where the function
is no longer short.  I'm going to keep it not inline.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux