Alex Williamson <[email protected]> wrote:
>
> The patch below adds an alignment attribute to the buffer used in
> sys_sendmsg(). This eliminates an unaligned access warning on ia64.
>
Vaguely surprised that the compiler cannot be taught to do this.
>
> diff -r db9b9552a2b4 net/socket.c
> --- a/net/socket.c Sat Sep 24 23:56:08 2005
> +++ b/net/socket.c Mon Sep 26 13:44:09 2005
> @@ -1700,7 +1700,9 @@
> struct socket *sock;
> char address[MAX_SOCK_ADDR];
> struct iovec iovstack[UIO_FASTIOV], *iov = iovstack;
> - unsigned char ctl[sizeof(struct cmsghdr) + 20]; /* 20 is size of ipv6_pktinfo */
> + unsigned char ctl[sizeof(struct cmsghdr) + 20]
> + __attribute__ ((aligned (sizeof(__kernel_size_t))));
> + /* 20 is size of ipv6_pktinfo */
> unsigned char *ctl_buf = ctl;
> struct msghdr msg_sys;
> int err, ctl_len, iov_size, total_len;
OK, thanks - I'll send this on to davem. It seems odd to be using
__kernel_size_t rather than size_t, but that's what struct cmshdr does
(also oddly).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |