Hi,
> > +#ifdef CONFIG_SYSFS
> Does anyone build a s390 kernel without sysfs? You can probably just
> drop this ifdef.
Yes, you're right.
> > +DEFINE_IPL_ATTR(lun, "0x%016llx\n", (unsigned long long)
> > +DEFINE_IPL_ATTR(bootprog, "%lld\n", (unsigned long long)
> Why have a format field, if you only use the same format?
I use two different formats (hexadecimal and decimal).
> > + __ATTR(device, S_IRUGO, ipl_device_show, NULL);
> Why not use __ATTR_RO() like you did above?
The name of the attribute is supposed to be 'device'. If I would use
__ATTR_RO it stringifies the first parameter and the result would be
'ipl_device' because of the function name I use.
Otherwise I would have to rename my function, which is something I
don't want to do. Somehow __ATTR_RO doesn't fit.
> > +#define IPL_PARMBLOCK_ORIGIN 0x2000
> You are just directly addressing memory with this address, right?
Yes.
> Shouldn't you iomap it or something first?
No, we don't have memory mapped IO on S390.
How about this:
From: Heiko Carstens <[email protected]>
Remove unnecessary ifdef + unused variable.
Signed-off-by: Heiko Carstens <[email protected]>
diffstat:
arch/s390/kernel/setup.c | 6 ------
1 file changed, 6 deletions(-)
diff -urN a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c
--- a/arch/s390/kernel/setup.c 2005-09-26 10:48:31.000000000 +0200
+++ b/arch/s390/kernel/setup.c 2005-09-26 11:01:12.000000000 +0200
@@ -686,8 +686,6 @@
.show = show_cpuinfo,
};
-#ifdef CONFIG_SYSFS
-
#define DEFINE_IPL_ATTR(_name, _format, _value) \
static ssize_t ipl_##_name##_show(struct subsystem *subsys, \
char *page) \
@@ -847,7 +845,6 @@
static int __init
ipl_device_sysfs_register(void) {
- struct attribute_group *attr_group;
int rc;
rc = firmware_register(&ipl_subsys);
@@ -868,12 +865,9 @@
default:
sysfs_create_group(&ipl_subsys.kset.kobj,
&ipl_unknown_attr_group);
- attr_group = &ipl_unknown_attr_group;
break;
}
return 0;
}
__initcall(ipl_device_sysfs_register);
-
-#endif /* CONFIG_SYSFS */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |