Re: [PATCH 17/21] mm: batch updating mm_counters

[Hugh Dickins <hugh@veritas.com>]

On Mon, 26 Sep 2005, Nick Piggin wrote:
> On Sun, 2005-09-25 at 17:08 +0100, Hugh Dickins wrote:
> > -		copy_one_pte(dst_mm, src_mm, dst_pte, src_pte, vm_flags, addr);
> > +		anon = copy_one_pte(dst_mm, src_mm, dst_pte, src_pte,
> > +							vm_flags, addr);
> > +		rss[anon]++;
> 
> How about passing rss[2] to copy_one_pte, and have that
> increment the correct rss value accordingly? Not that
> you may consider that any nicer than what you have here.

That does seem a more _normal_ way of doing it.

Though adding a seventh argument doesn't appeal
(perhaps irrelevant since copy_one_pte is inlined).

I don't mind much either way: anyone have strong feelings?

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/