Re: [PATCH] Unify sys_tkill() and sys_tgkill()

[Jesper Juhl <jesper.juhl@gmail.com>]

On 9/24/05, Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:
> On Sat, 24 September 2005 16:52:28 +0200, Jesper Juhl wrote:
> >
> > [snip]
> > > +static int do_tkill(int tgid, int pid, int sig)
> >
> > I would probably have made this
> >
> >   static inline int do_tkill(int tgid, int pid, int sig)
>
> Why?  It would only return the original duplication in binary form and
> save a minimal amount of time for something already slow - a system
> call.  With small caches, the code duplication could even waste more
> performance than the missing function call would gain you.
>
You are right, I didn't think that through properly.
Thank you for catching that.

> Other nits were well-picked.
>
Thanks.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/