Re: [PATCH 3/3] fuse: check O_DIRECT

> > +	/* VFS checks this, but only _after_ ->open() */
> > +	if (file->f_flags & O_DIRECT)
> > +		return -EINVAL;
> > +
> >  	err = generic_file_open(inode, file);
> >  	if (err)
> >  		return err;
> 
> This hardly seems worth optimising for?

It could be a correctness issue too: if filesystem has open() with
side effect, then it should fail before doing the open, not after.

Not a big deal, but I think it's worth the 3 lines.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 3/3] fuse: check O_DIRECT
    • From: Miklos Szeredi <[email protected]>
  • Re: [PATCH 3/3] fuse: check O_DIRECT
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] open: O_DIRECTORY and O_CREAT together should fail
• Next by Date: Re: [PATCH] open: O_DIRECTORY and O_CREAT together should fail
• Previous by thread: Re: [PATCH 3/3] fuse: check O_DIRECT
• Next by thread: *** Announcement: dmraid 1.0.0.rc9 ***
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]