Re: making kmalloc BUG() might not be a good idea

David S. Miller wrote:

I'm sort-of concerned about this change:

   [PATCH] __kmalloc: Generate BUG if size requested is too large.

it opens a can of worms, and stuff that used to generate
-ENOMEM kinds of failures will now BUG() the kernel.

Unless you're going to audit every user triggerable
path for proper size limiting, I think we should revert
this change.

Thanks.

Making it WARN might be a good compromise.

Send instant messages to your online friends http://au.messenger.yahoo.com -

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: making kmalloc BUG() might not be a good idea
    • From: Ingo Oeser <[email protected]>
  • Re: making kmalloc BUG() might not be a good idea
    • From: "David S. Miller" <[email protected]>

• References:
  • making kmalloc BUG() might not be a good idea
    • From: "David S. Miller" <[email protected]>

• Prev by Date: Re: I request inclusion of reiser4 in the mainline kernel
• Next by Date: Re: [ANNOUNCE] ktimers subsystem
• Previous by thread: making kmalloc BUG() might not be a good idea
• Next by thread: Re: making kmalloc BUG() might not be a good idea
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]