On Wed, Sep 21, 2005 at 11:32:24PM +0200, Eric Dumazet wrote: > Patch 2/3 (please apply after Patch 1/3) > > 2) Loop unrolling First of all, thanks for your performance analysis and patches. I'm very inclined of merging them. > It seems that with current compilers and CFLAGS, the code from > ip_packet_match() is very bad, using lot of mispredicted conditional branches I made some patches > and generated code on i386 and x86_64 > is much better. This only describes your "compare_if_lstrings()" changes, and I'm happy to merge them. However, you also removed the use of the FWINV macro and replaced it by explicit code (including the bool1/bool2 variables, which are not really named intuitively). Why was this neccessary? -- - Harald Welte <[email protected]> http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie
Attachment:
pgpjpVGc32Wan.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH 2/3] netfilter : 3 patches to boost ip_tables performance
- From: Eric Dumazet <[email protected]>
- Re: [PATCH 2/3] netfilter : 3 patches to boost ip_tables performance
- References:
- [PATCH] Adds sys_set_mempolicy() in include/linux/syscalls.h , Re: [PATCH, netfilter] NUMA aware ipv4/netfilter/ip_tables.c
- From: Eric Dumazet <[email protected]>
- [PATCH] Adds sys_set_mempolicy() in include/linux/syscalls.h
- From: Eric Dumazet <[email protected]>
- [PATCH 2/3] netfilter : 3 patches to boost ip_tables performance
- From: Eric Dumazet <[email protected]>
- [PATCH] Adds sys_set_mempolicy() in include/linux/syscalls.h , Re: [PATCH, netfilter] NUMA aware ipv4/netfilter/ip_tables.c
- Prev by Date: Re: A pettiness question.
- Next by Date: Re: [PATCH 0/3] netfilter : 3 patches to boost ip_tables performance
- Previous by thread: [PATCH 2/3] netfilter : 3 patches to boost ip_tables performance
- Next by thread: Re: [PATCH 2/3] netfilter : 3 patches to boost ip_tables performance
- Index(es):
