Re: [Fastboot] [PATCH] Kdump(x86): add note type NT_KDUMPINFO to kernel core dumps

[Vivek Goyal <vgoyal@in.ibm.com>]

On Thu, Sep 22, 2005 at 12:46:48AM -0700, Andrew Morton wrote:
> Vivek Goyal <vgoyal@in.ibm.com> wrote:
> >
> > > - Why do you avoid storing the current task on the other cpus?
> >  > 
> >  > - Can't we derive the current task from the existing register information
> >  >   already captured.  
> > 
> >  It can be done but as Dave suggested but that requires significant amount 
> >  of job to be done as one has to traverse through the active task stacks and
> >  look for crash_kexec(). An easier/simpler way is that kernel itself can 
> >  report it.  Netdump, diskdump already do it. I think for simplicity, it 
> >  makes sense to export this information from kernel in the form of note.
> > 
> >  Only issue I could think of is stack overflow and current might be 
> >  corrupted after panic.
> > 
> 
> Yes, traversing the task_structs in a crashed kernel sounds like a poor
> idea.
> 

Andrew, traversal of task_structs will not be done in crashed kernel. It
will be done in user space by "crash" (if required, during post crash analysis).

In this case we are simply copying "current" pointer of panicking task in 
an elf note.

	kdumpinfo.panic_tsk = current;

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/