Hugh Dickins wrote:
On Wed, 21 Sep 2005, Frank van Maarseveen wrote:
This fixes a post 2.6.11 regression in maintaining the mm->hiwater_* counters.
It would be a good idea to CC Christoph Lameter, who I believe was the
one who very intentionally moved most of these updates out to timer tick.
Is that significantly missing updates?
If it turns out that your patch is appropriate:
1. The change from tsk to mm is good (but not urgent 2.6.14 material).
2. You've missed the instance Dave Miller recently added in fs/compat.c.
3. If these are to be peppered back all over, then the places where
total_vm changes and the places where rss changes are almost completely
disjoint, so it's lazy to be calling one function to do both all over.
4. If you've noticed a regression, you must be one of the elite that knows
what these counters are used for: nothing in the kernel.org tree does.
Please add a comment saying what it is that uses them and how, so
developers can make better judgements about how best to maintain them.
5. Please add appropriate CONFIG, dummy macros etc., so that no time
is wasted on these updates in all the vanilla systems which have no
interest in them - but maybe Christoph already has that well in hand.
It is used in enhanced system accounting. An obvious CONFIG would be
CONFIG_BSD_PROCESS_ACCT.
However, since the CONFIG flag is almost always Yes, people would need
to turn it off if they do not want system accounting. Would that be
OK?
Thanks,
- jay
Sorry for the rifle fire, you did put your head above the parapet!
Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |