Re: [PATCH] NTP shift_right cleanup (v. A3)

• To: john stultz <[email protected]>
• Subject: Re: [PATCH] NTP shift_right cleanup (v. A3)
• From: Nick Piggin <[email protected]>
• Date: Wed, 21 Sep 2005 15:24:38 +1000
• Cc: Andrew Morton <[email protected]>, lkml <[email protected]>, [email protected], George Anzinger <[email protected]>, Ulrich Windl <[email protected]>, Roman Zippel <[email protected]>, [email protected]
• Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=N/2shucgZoXUzohetumgxEpf7mkw7+wFHzIB6U+K6NSPinUDjqiyEtpsu2GiGB7IC8y5y3J26qbFrX8V6DO3RFJxiWXn2JOK/iNDd/oV/5JiblkzljGd8I0nyDSBX+FHlc+mLHaiwORZpvPHEnS9N+JsJR6JPaEynLTr4onZ80E= ;
• In-reply-to: <[email protected]>
• References: <[email protected]> <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Debian/1.7.8-1

john stultz wrote:

+/* Required to safely shift negative values */
+#define shift_right(x, s) ({	\
+	__typeof__(x) __x = (x);	\
+	__typeof__(s) __s = (s);	\
+	__x < 0 ? -(-__x >> __s) : __x >> __s;	\
+})
+

I'd hate to be the one to make you do another version of this ;)

However, how about having something more descriptive than shift_right?
signed_shift_right / shift_right_signed, maybe?

Nick

Send instant messages to your online friends http://au.messenger.yahoo.com -

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] NTP shift_right cleanup (v. A3)
    • From: "Ulrich Windl" <[email protected]>

• References:
  • [RFC][PATCH] NTP shift_right cleanup (v. A1)
    • From: john stultz <[email protected]>
  • [PATCH] NTP shift_right cleanup (v. A2)
    • From: john stultz <[email protected]>
  • [PATCH] NTP shift_right cleanup (v. A3)
    • From: john stultz <[email protected]>

• Prev by Date: Re: help interpreting oom-killer output
• Next by Date: Re: one more oops on sensor modules removal
• Previous by thread: [PATCH] NTP shift_right cleanup (v. A3)
• Next by thread: Re: [PATCH] NTP shift_right cleanup (v. A3)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]