Re: p = kmalloc(sizeof(*p), )

Linus Torvalds <[email protected]> writes:
> Actually, some day that migth be a good idea, but at least historically, 
> gcc has really really messed that kind of code up.
>
> Last I looked, depending on what the initializer was, gcc would create a 
> temporary struct on the stack first, and then do a "memcpy()" of the 
> result.

A little test shows:

gcc-3.4.4 seems to still do what you describe.

gcc-4.0.1 seems to  it the "right" way (writing each field directly to
the destination structure).

Someday...

-miles
-- 
Yo mama's so fat when she gets on an elevator it HAS to go down.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • p = kmalloc(sizeof(*p), )
    • From: Russell King <[email protected]>
  • Re: p = kmalloc(sizeof(*p), )
    • From: Robert Love <[email protected]>
  • Re: p = kmalloc(sizeof(*p), )
    • From: Willy Tarreau <[email protected]>
  • Re: p = kmalloc(sizeof(*p), )
    • From: Al Viro <[email protected]>
  • Re: p = kmalloc(sizeof(*p), )
    • From: Linus Torvalds <[email protected]>

• Prev by Date: Re: readme-update-from-the-stone-age.patch added to -mm tree
• Next by Date: Re: [patch] stop inotify from sending random DELETE_SELF event under load
• Previous by thread: Re: p = kmalloc(sizeof(*p), )
• Next by thread: Re: p = kmalloc(sizeof(*p), )
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]