Re: [PATCH 2/2] suspend: Cleanup calling of power off methods.

Hi!

> In the lead up to 2.6.13 I fixed a large number of reboot
> problems by making the calling conventions consistent.  Despite
> checking and double checking my work it appears I missed an
> obvious one.
> 
> The S4 suspend code for PM_DISK_PLATFORM was also calling
> device_shutdown without setting system_state, and was
> not calling the appropriate reboot_notifier.

ACK on both. But should not you submit patch via -mm, so it gets at
least some testing there?
								Pavel
-- 
if you have sharp zaurus hardware you don't need... you know my address
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/2] suspend: Cleanup calling of power off methods.
    • From: [email protected] (Eric W. Biederman)

• References:
  • RE: reboot vs poweroff
    • From: "Brown, Len" <[email protected]>
  • Re: reboot vs poweroff
    • From: [email protected] (Eric W. Biederman)
  • Re: reboot vs poweroff
    • From: Meelis Roos <[email protected]>
  • [PATCH 1/2] reboot: Comment and factor the main reboot functions
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 2/2] suspend: Cleanup calling of power off methods.
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: Arrr! Linux v2.6.14-rc2
• Next by Date: Re: I request inclusion of reiser4 in the mainline kernel
• Previous by thread: [PATCH 2/2] suspend: Cleanup calling of power off methods.
• Next by thread: Re: [PATCH 2/2] suspend: Cleanup calling of power off methods.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]