Re: [patch] stop inotify from sending random DELETE_SELF event under load

[John McCutchan <ttb@tentacle.dhs.org>]

On Tue, 2005-09-20 at 04:33 +0100, Al Viro wrote:
> On Mon, Sep 19, 2005 at 10:00:41PM -0400, John McCutchan wrote:
> > To quote you:
> > 
> > Instead of the broken fsnotify_unlink/fsnotify_rmdir functions, you can 
> > split this into two logically _different_ functions:
> > 
> >  - fsnotify_nameremove(dentry) - called when the dentry goes away
> >  - fsnotify_inoderemove(dentry) - called when the inode goes away
> > 
> > ...
> > 
> > The fsnotify_inoderemove() is called from dentry_iput(), and that's the 
> > one that specifies that an actual inode no longer exists.
> > 
> > 
> > ;)
> 
> That was wrong.  Just have *one* function (on link removal) and stuff
> i_mode and i_nlink of victim into event.

We have already locked down the ABI of the event structure. Hopefully
Linus's patch will fix this in a clean way.

-- 
John McCutchan <ttb@tentacle.dhs.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/