Re: [PATCH] Au1x00 8250 uart support.

>  static _INLINE_ unsigned int serial_in(struct uart_8250_port *up, int offset)
>  {
> +#ifdef CONFIG_SERIAL_8250_AU1X00
> +	if (up->port.iotype == UPIO_AU)
> +		offset = au_io_in_map[offset];
> +#endif

All this ifdef stuff is rather messy.  Allowing the driver to specity a map
in some structure might make more sense.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Au1x00 8250 uart support.
    • From: Pantelis Antoniou <[email protected]>

• References:
  • [PATCH] Au1x00 8250 uart support.
    • From: Pantelis Antoniou <[email protected]>

• Prev by Date: Re: I request inclusion of reiser4 in the mainline kernel
• Next by Date: RE: Multi-Threaded fork() correctness on Linux 2.4 & 2.6
• Previous by thread: [PATCH] Au1x00 8250 uart support.
• Next by thread: Re: [PATCH] Au1x00 8250 uart support.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]