"David S. Miller" <[email protected]> writes:
> From: Ed L Cashin <[email protected]>
> Date: Mon, 19 Sep 2005 10:24:00 -0400
>
>> 1) Passing le64_to_cpup an unaligned pointer is "OK" and within the
>> intended use of the function. I'm having trouble finding whether
>> this is documented somewhere.
>>
>> 2) These new changes to the sparc64 unaligned access fault handling
>> will make it OK to leave the aoe driver the way it is in the
>> mainline kernel.
>
> Both #1 and #2 are true.
That's interesting. I think I'll send a patch documenting #1.
> Although it's very much discouraged to dereference unaligned pointers,
> especially in performance critical code (which this AOE case is not,
> thankfully), because performance will be really bad as the trap
> handler has to fix up the access on RISC platforms.
Yes, this only happens when per AoE device when the AoE device is
discovered. Still, I might submit a patch that reverts the aoe driver
to getting the ATA identify values byte by byte as it used to do.
--
Ed L Cashin <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |