Re: [linux-usb-devel] URB_ASYNC_UNLINK b0rkage

[Alan Stern <stern@rowland.harvard.edu>]

On Sun, 18 Sep 2005, Alexey Dobriyan wrote:

> Perhaps, another press release to explain breakage of allmodconfig is
> needed.
> ------------------------------------------------------------------------
> drivers/usb/host/hc_crisv10.c:	if (urb->transfer_flags & URB_ASYNC_UNLINK) {
> drivers/usb/host/hc_crisv10.c:		/* If URB_ASYNC_UNLINK is set:
> drivers/usb/host/hc_crisv10.c:		warn("URB_ASYNC_UNLINK set, ignoring.");
> drivers/usb/misc/uss720.c:	/* rq->urb->transfer_flags |= URB_ASYNC_UNLINK; */
> drivers/isdn/hisax/st5481_b.c:	b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> drivers/isdn/hisax/st5481_b.c:	b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> drivers/isdn/hisax/st5481_usb.c:	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> drivers/isdn/hisax/st5481_usb.c:	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> Documentation/usb/URB.txt:the URB_ASYNC_UNLINK flag in urb->transfer flags before calling

hc_crisv10 is long out-of-date and doesn't even build, as you saw.  Is 
anyone still using it?  It probably should be removed from the Makefile.

The line in drivers/usb/misc/uss720.c is just a comment.  Presumably it 
can be taken out with no harm done.

In my kernel tree, the st5481 source files don't include the lines you 
show.  What source version are you using?

Finally, the URB.txt documentation file clearly states at the beginning 
that it is out of date.  However it wouldn't hurt to fix it up a little.  
I'll send in a patch to do so.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/