From: Paolo 'Blaisorblade' Giarrusso <[email protected]>
Add sparse annotations and add some missing "static" to hppfs_kern.c - no
bug fixed in this patch. There's still a warning - but sparse can't
understand set_fs(KERNEL_DS) it seems.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
---
fs/hppfs/hppfs_kern.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/hppfs/hppfs_kern.c b/fs/hppfs/hppfs_kern.c
--- a/fs/hppfs/hppfs_kern.c
+++ b/fs/hppfs/hppfs_kern.c
@@ -104,7 +104,7 @@ static char *dentry_name(struct dentry *
return(name);
}
-struct dentry_operations hppfs_dentry_ops = {
+static struct dentry_operations hppfs_dentry_ops = {
};
static int file_removed(struct dentry *dentry, const char *file)
@@ -226,10 +226,10 @@ static struct inode_operations hppfs_fil
* We also know if we're called from userspace from is_user, which is used for
* set_fs(). I'm leaving this redundancy to bite any wrong caller.
*/
-static ssize_t read_proc(struct file *file, char *buf, ssize_t count,
+static ssize_t read_proc(struct file *file, char __user *buf, ssize_t count,
loff_t *ppos, int is_user)
{
- ssize_t (*read)(struct file *, char *, size_t, loff_t *);
+ ssize_t (*read)(struct file *, char __user *, size_t, loff_t *);
ssize_t n;
mm_segment_t old_fs;
@@ -256,7 +256,7 @@ static ssize_t read_proc(struct file *fi
return n;
}
-static ssize_t hppfs_read_file(int fd, char *buf, ssize_t count)
+static ssize_t hppfs_read_file(int fd, char __user *buf, ssize_t count)
{
ssize_t n;
int cur, ret;
@@ -296,7 +296,7 @@ out:
return n;
}
-static ssize_t hppfs_read(struct file *file, char *buf, size_t count,
+static ssize_t hppfs_read(struct file *file, char __user *buf, size_t count,
loff_t *ppos)
{
struct hppfs_private *hppfs = file->private_data;
@@ -353,12 +353,12 @@ static ssize_t hppfs_read(struct file *f
return written;
}
-static ssize_t hppfs_write(struct file *file, const char *buf, size_t len,
+static ssize_t hppfs_write(struct file *file, const char __user *buf, size_t len,
loff_t *ppos)
{
struct hppfs_private *data = file->private_data;
struct file *proc_file = data->proc_file;
- ssize_t (*write)(struct file *, const char *, size_t, loff_t *);
+ ssize_t (*write)(struct file *, const char __user *, size_t, loff_t *);
int err;
write = proc_file->f_dentry->d_inode->i_fop->write;
@@ -710,7 +710,7 @@ static struct inode *hppfs_alloc_inode(s
return(&hi->vfs_inode);
}
-void hppfs_delete_inode(struct inode *ino)
+static void hppfs_delete_inode(struct inode *ino)
{
clear_inode(ino);
}
@@ -728,11 +728,11 @@ static struct super_operations hppfs_sbo
.statfs = hppfs_statfs,
};
-static int hppfs_readlink(struct dentry *dentry, char *buffer, int buflen)
+static int hppfs_readlink(struct dentry *dentry, char __user *buffer, int buflen)
{
struct file *proc_file;
struct dentry *proc_dentry;
- int (*readlink)(struct dentry *, char *, int);
+ int (*readlink)(struct dentry *, char __user *, int);
int ret;
proc_dentry = HPPFS_I(dentry->d_inode)->proc_dentry;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |