Re: [RFC PATCH 1/10] vfs: Lindentified namespace.c

[Alexey Dobriyan <adobriyan@gmail.com>]

On Fri, Sep 16, 2005 at 11:26:19AM -0700, Ram wrote:
> Lindentified fs/namespace.c
> 
> Signed by Ram Pai (linuxram@us.ibm.com)

Signed-off-by: ... <...>

> --- 2.6.13.sharedsubtree.orig/fs/namespace.c
> +++ 2.6.13.sharedsubtree/fs/namespace.c

> -	unsigned long tmp = ((unsigned long) mnt / L1_CACHE_BYTES);
> -	tmp += ((unsigned long) dentry / L1_CACHE_BYTES);
> +	unsigned long tmp = ((unsigned long)mnt / L1_CACHE_BYTES);
> +	tmp += ((unsigned long)dentry / L1_CACHE_BYTES);

Could you do it by hand? In the folllowing case indent made code look
worse. In particular, all labels are moved to column 7.

> -static void *m_start(struct seq_file *m, loff_t *pos)
> +static void *m_start(struct seq_file *m, loff_t * pos)

*pos

>  	list_for_each(p, &n->list)
> -		if (!l--)
> -			return list_entry(p, struct vfsmount, mnt_list);
> +	    if (!l--)
> +		return list_entry(p, struct vfsmount, mnt_list);

> -static void *m_next(struct seq_file *m, void *v, loff_t *pos)
> +static void *m_next(struct seq_file *m, void *v, loff_t * pos)

>  struct seq_operations mounts_op = {
> -	.start	= m_start,
> -	.next	= m_next,
> -	.stop	= m_stop,
> -	.show	= show_vfsmnt
> +	.start = m_start,
> +	.next = m_next,
> +	.stop = m_stop,
> +	.show = show_vfsmnt

> -repeat:
> +      repeat:
>  	next = this_parent->mnt_mounts.next;

> -	while(d_mountpoint(nd->dentry) && follow_down(&nd->mnt, &nd->dentry))
> -		;
> +	while (d_mountpoint(nd->dentry) && follow_down(&nd->mnt, &nd->dentry)) ;

> -	while(d_mountpoint(nd->dentry) && follow_down(&nd->mnt, &nd->dentry))
> -		;
> +	while (d_mountpoint(nd->dentry) && follow_down(&nd->mnt, &nd->dentry)) ;

> -exact_copy_from_user(void *to, const void __user *from, unsigned long n)
> +exact_copy_from_user(void *to, const void __user * from, unsigned long n)

> -int copy_mount_options(const void __user *data, unsigned long *where)
> +int copy_mount_options(const void __user * data, unsigned long *where)

> -	
> +

> -	} while_each_thread(g, p);
> +	}
> +	while_each_thread(g, p);

> -		goto out2; /* loop, on the same file system  */
> +		goto out2;	/* loop, on the same file system  */

> -		goto out2; /* not a mountpoint */
> +		goto out2;	/* not a mountpoint */

> -		goto out2; /* not a mountpoint */
> -	tmp = old_nd.mnt; /* make sure we can reach put_old from new_root */
> +		goto out2;	/* not a mountpoint */
> +	tmp = old_nd.mnt;	/* make sure we can reach put_old from new_root */

> -				goto out3; /* already mounted on put_old */
> +				goto out3;	/* already mounted on put_old */

> -	attach_mnt(user_nd.mnt, &old_nd);     /* mount old root on put_old */
> -	attach_mnt(new_nd.mnt, &root_parent); /* mount new_root on / */
> +	attach_mnt(user_nd.mnt, &old_nd);	/* mount old root on put_old */
> +	attach_mnt(new_nd.mnt, &root_parent);	/* mount new_root on / */

> -	} while_each_thread(g, p);
> +	}
> +	while_each_thread(g, p);

>  	mount_hashtable = (struct list_head *)
> -		__get_free_page(GFP_ATOMIC);
> +	    __get_free_page(GFP_ATOMIC);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/