Re: [PATCH] more sigkill priority fix

[Atsushi Nemoto <anemo@mba.ocn.ne.jp>]

Adding Kirill Korotaev and Heiko Carstens to CC.

>>>>> On Thu, 08 Sep 2005 01:24:50 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> said:

anemo> On Linux/MIPS, a simple test program can create unkillable
anemo> process.  The "sigkill priority fix" was introduced in 2.6.12,
anemo> but it does not effective for signals sent by force_sig() in
anemo> kernel.  For detailed behavior and testcase, please look at
anemo> this thread in linux-mips ML:

This is fixed by another way in 2.6.14-rc1 for i386 (Thanks, Roland).
The changelog line is:

>    [PATCH] i386: Don't miss pending signals returning to user mode after signal processing
>    Signed-off-by: Roland McGrath <roland@redhat.com>

And now similar fix for mips is already in Linux/MIPS CVS tree too.

--- linux-mips/arch/mips/kernel/entry.S	2005-03-04 22:17:29.000000000 +0900
+++ linux/arch/mips/kernel/entry.S	2005-09-16 01:04:52.365022536 +0900
@@ -105,7 +105,7 @@
 	move	a0, sp
 	li	a1, 0
 	jal	do_notify_resume	# a2 already loaded
-	j	restore_all
+	j	resume_userspace
 
 FEXPORT(syscall_exit_work_partial)
 	SAVE_STATIC


I suppose the original problem on s390 (reported by Heiko Carstens)
could be fixed same way.  Then 'sigkill priority fix' would be
reverted safely.

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/