On Thu, Sep 15, 2005 at 02:23:53PM -0700, Linus Torvalds wrote:
>
> Gaah.
>
> On Thu, 15 Sep 2005, Al Viro wrote:
> > { /* Begin post_fep_init */
> >
> > int i;
> > - unsigned char *memaddr;
> > - struct global_data *gd;
> > + unsigned char __iomem *memaddr;
> > + struct global_data __iomem *gd;
>
> Please don't use "[unsigned] char __iomem *".
Not a problem, I simply wanted to keep __iomem stuff apart from driver
cleanups.
> Why? Two reasons:
[obvious - we are in full agreement here]
> I bet the patch would look like a nice cleanup if you did that. Hint,
> hint.
OK... I'd rather do that as an incremental, to keep unrelated changes
separate, but I can merge them if you prefer it that way.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |