Re: [patch 09/28] Input: convert net/bluetooth to dynamic input_dev allocation

[Vojtech Pavlik <vojtech@suse.cz>]

On Thu, Sep 15, 2005 at 02:22:34PM -0500, Dmitry Torokhov wrote:
> On 9/15/05, Vojtech Pavlik <vojtech@suse.cz> wrote:
> > On Thu, Sep 15, 2005 at 04:41:50PM +0200, Marcel Holtmann wrote:
> > > Hi Dmitry,
> > >
> > > > > > Input: convert net/bluetooth to dynamic input_dev allocation
> > > > > >
> > > > > > This is required for input_dev sysfs integration
> > > > > >
> > > > > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> > > > >
> > > > > on the condition your stuff got merged, then this patch is ok with me.
> > > > >
> > > > > Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> > > > >
> > > >
> > > > I was planning on getting patch 8 (preparation patch) into kernel ASAP
> > > > and then just sending individual subsystem patches to maintainers and
> > > > Andrew so they can merge at their leisure (but don't wait for too long
> > > > ;))
> > >
> > > I have no problem with you submitting the changes. If Vojtech is fine
> > > with the proposed way, I would say that we get all of these changes into
> > > mainline now. The device model integration is long overdue.
> > 
> > I'm fine with it, yes. I'm not completely convinced that an input device
> > is really a class and not a device. ;) But I can understand that view.
> 
> They are devices - class devices :). I have the following distinction
> in my head - "normal" devices (bus devices) are real hardware devices
> and their drivers need to do resource and/or power management. Class
> devices represent virtual devices - some kind of abstraction - that
> unify and combine "real" devices from several buses into one class.

Yes. While input drivers do need to care about power management usually,
the input device abstraction itself doesn't have to, which makes it
indeed a special kind of a device.

> And of course nothing shoudl stop us from building class devices on
> top of other class devices, if needed.

I was always wondering whether the distinction between bus/class was
needed, as the border isn't very clear.

> Anyway, I think if Greg gives up and agrees on nesting classes all of
> it can go in -mm for now and I will contact other maintainers to
> verify that changes work. IIRC video/dvb mainatiners prefered all
> changes to go through them.
> 
> In any case I don't expect it reach Linus until after 2.6.14 released
> - do you agree?
 
Yup.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/