Re: [PATCH] Permanently fix kernel configuration include mess

[Josh Boyer <jdub@us.ibm.com>]

On Tue, 2005-09-13 at 15:10 -0400, Brian Gerst wrote:
> Russell King wrote:
> > On Tue, Sep 13, 2005 at 05:59:54PM +0100, Joern Engel wrote:
> > 
> >>On Tue, 13 September 2005 15:50:12 +0100, Russell King wrote:
> >>
> >>>Subject: [KBUILD] Permanently fix kernel configuration include mess.
> >>>
> >>>Include autoconf.h into every kernel compilation via the gcc
> >>>command line using -imacros.  This ensures that we have the
> >>>kernel configuration included from the start, rather than
> >>>relying on each file having #include <linux/config.h> as
> >>>appropriate.  History has shown that this is something which
> >>>is difficult to get right.
> >>>
> >>>Since we now include the kernel configuration automatically,
> >>>make configcheck becomes meaningless, so remove it.
> >>>
> >>>Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> >>
> >>If it helps:
> >>Signed-off-by: Joern Engel <joern@wh.fh-wedel.de>
> > 
> > 
> > Might help more if I copied (or sent this to) akpm. 8)
> > 
> > diff --git a/Makefile b/Makefile
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -346,7 +346,8 @@ AFLAGS_KERNEL	=
> >  # Use LINUXINCLUDE when you must reference the include/ directory.
> >  # Needed to be compatible with the O= option
> >  LINUXINCLUDE    := -Iinclude \
> > -                   $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include)
> > +                   $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> > +		   -imacros include/linux/autoconf.h
> >  
> >  CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
> >  
> > @@ -1247,11 +1248,6 @@ tags: FORCE
> >  # Scripts to check various things for consistency
> >  # ---------------------------------------------------------------------------
> >  
> > -configcheck:
> > -	find * $(RCS_FIND_IGNORE) \
> > -		-name '*.[hcS]' -type f -print | sort \
> > -		| xargs $(PERL) -w scripts/checkconfig.pl
> > -
> >  includecheck:
> >  	find * $(RCS_FIND_IGNORE) \
> >  		-name '*.[hcS]' -type f -print | sort \
> > 
> > 
> 
> The patch should also remove the checkconfig.pl script.

That could probably be done in a later cleanup patch that removes all
"#include <linux/config.h>" statements as well.  Sounds like a job for
the kernel janitors project.

josh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/