Re: [PATCH 1/2] New Omnikey Cardman 4040 driver

On 9/13/05, Harald Welte <[email protected]> wrote:
> Hi!
> 
> I've now incorporated all requested/suggested changes. Please apply the
> following patch to the mainline tree, thanks!

<snip>

> diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c

<snip>

> +static ssize_t cm4040_read(struct file *filp, char __user *buf,
> +                       size_t count, loff_t *ppos)
> +{

<snip>

> +       schedule_timeout(1*HZ);

This needs a state set, or it will return immediately. Use either
schedule_timeout_interruptible() or schedule_timeout_uninterruptible()
(merged in 2.6.14-rc1). Otherwise the patches look good.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] New Omnikey Cardman 4040 driver
    • From: Harald Welte <[email protected]>

• References:
  • [PATCH 1/2] New Omnikey Cardman 4040 driver
    • From: Harald Welte <[email protected]>

• Prev by Date: [patch 5/11] mm: Bigrefs -- add_getcpuptr
• Next by Date: [patch 6/11] mm: Bigrefs -- distributed refcounters
• Previous by thread: [PATCH 1/2] New Omnikey Cardman 4040 driver
• Next by thread: Re: [PATCH 1/2] New Omnikey Cardman 4040 driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]