Re: [1/3] Add 4GB DMA32 zone

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Mon, 12 Sep 2005, Andi Kleen wrote:

> > On Sun, 11 Sep 2005, Andi Kleen wrote:
> > > -#define MAX_NR_ZONES		3	/* Sync this with ZONES_SHIFT */
> > > -#define ZONES_SHIFT		2	/* ceil(log2(MAX_NR_ZONES)) */
> > > +#define MAX_NR_ZONES		4	/* Sync this with ZONES_SHIFT */
> > > +#define ZONES_SHIFT		3	/* ceil(log2(MAX_NR_ZONES)) */
> >
> > Why needs ZONES_SHIFT to be increased?
> >
> > > -#define FLAGS_RESERVED		8
> > > +#define FLAGS_RESERVED		9
> >
> > I would prefer to keep this at 8.
> 
> sparsemem needs these two.

Did I somehow offend you, that I don't deserve an answer?
The reason for my question is rather simple (and I thought obvious), the 
four zone types fit into two bits, so what is sparsemem doing with this 
extra bit?

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/