Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf

Michal Piotrowski <[email protected]> wrote:
>
> Hi,
> 
> On 12/09/05, Alexander Nyberg <[email protected]> wrote:
> > 
> > Gah, I'm such a fantastic programmer.
> > 
> > I don't know what mc is up to but the error checking in read_page_owner
> > is flawed wrt snprintf which could cause the 'size' argument to snprintf
> > to become negative and if so overwrite beyond 'buf'.
> > 
> > Again, I fail to see how mc causes this to happen, but this fixes it
> > by proper error checking.
> > 
> > Signed-off-by: Alexander Nyberg <[email protected]>
> 
> Thanks, patch solved problem.

Thanks.

> Here is version, that clean apply on 2.6.13-mm3. Can you review it?

That patch is all wordwrapped.

How doe sit differe from Alex's patch?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf
    • From: Michal Piotrowski <[email protected]>

• References:
  • 2.6.13-mm3
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf
    • From: Michal Piotrowski <[email protected]>
  • Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf
    • From: Alexander Nyberg <[email protected]>
  • Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf
    • From: Michal Piotrowski <[email protected]>

• Prev by Date: Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
• Next by Date: Re: 2.6.13-mm2
• Previous by thread: Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf
• Next by thread: Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]