Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()

Kirill Korotaev <[email protected]> wrote:
>
>  This patch fixes error path in setup_arg_pages() functions, since it 
>  misses vm_unacct_memory() after successful call of 
>  security_vm_enough_memory(). Also it cleans up error path.

Ugh.  The identifier `security_vm_enough_memory()' sounds like some
predicate which has no side-effects.  Except it performs accounting.  Hence
bugs like this.

It's a shame that you mixed a largeish cleanup along with a bugfix - please
don't do that in future.

Patch looks OK to me.  Hugh, could you please double-check sometime?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
    • From: Hugh Dickins <[email protected]>
  • Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
    • From: Kirill Korotaev <[email protected]>

• References:
  • [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: Re: [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single
• Next by Date: Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
• Previous by thread: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
• Next by thread: Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]