Re: [GIT PATCH] More PCI patches for 2.6.13

[Linus Torvalds <torvalds@osdl.org>]

On Sat, 10 Sep 2005, Andrew Morton wrote:
> 
> Who do I bug about these longstanding ppc64 warnings, btw ;)
> 
> drivers/scsi/sata_svw.c: In function `k2_sata_tf_load':
> drivers/scsi/sata_svw.c:111: warning: passing arg 2 of `eeh_writeb' makes pointer from integer without a cast
> drivers/scsi/sata_svw.c:116: warning: passing arg 2 of `eeh_writew' makes pointer from integer without a cast
> drivers/scsi/sata_svw.c:117: warning: passing arg 2 of `eeh_writew' makes pointer from integer without a cast

I used to have a patch to fix them, and sent it to Jeff ages ago. At that 
point, he didn't want to use the iomap() functionality, but maybe that has 
changed.

Jeff? It requires making almost all the SATA IO base pointers be iomapped: 
the current

	struct ata_ioports {
	        unsigned long           cmd_addr;
	        unsigned long           data_addr;
		...

would have to become

	struct ata_ioports {
		void __iomem *cmd_addr;
		void __iomem *data_addr;
		...

instead - and initialized with the proper ioport_map() or pci_iomap() as 
appropriate.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/