Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h)

[Jiri Slaby <jirislaby@gmail.com>]

Greg KH napsal(a):
> On Sat, Sep 10, 2005 at 04:55:10PM -0400, Jeff Garzik wrote:
>
> > Jiri Slaby wrote:
> >
> > > diff --git a/include/asm-i386/ide.h b/include/asm-i386/ide.h
> > > --- a/include/asm-i386/ide.h
> > > +++ b/include/asm-i386/ide.h
> > > @@ -41,7 +41,12 @@ static __inline__ int ide_default_irq(un
> > >
> > > static __inline__ unsigned long ide_default_io_base(int index)
> > > {
> > > -	if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) == NULL) {
> > > +	struct pci_dev *pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
> > > +	unsigned int a = !pdev;
> > > +
> > > +	pci_dev_put(pdev);
> >
> >
> > Looks like we need to resurrect pci_present() from the ancient past.
>
>
> Heh, ick, no :)
>
> Jiri, any other way to do this instead?
I have no idea, how to do it more elegant. So hint me a little bit...

thanks,
--
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@gmail.com      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/