Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)

Jiri Slaby wrote:

Signed-off-by: Jiri Slaby <[email protected]>

 specialix.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/char/specialix.c b/drivers/char/specialix.c
--- a/drivers/char/specialix.c
+++ b/drivers/char/specialix.c
@@ -2502,9 +2502,9 @@ static int __init specialix_init(void)
 				i++;
 				continue;
 			}

- pdev = pci_find_device (PCI_VENDOR_ID_SPECIALIX, - PCI_DEVICE_ID_SPECIALIX_IO8, - pdev);

+			pdev = pci_get_device (PCI_VENDOR_ID_SPECIALIX,
+					PCI_DEVICE_ID_SPECIALIX_IO8,
+					pdev);
 			if (!pdev) break;

if (pci_enable_device(pdev))

@@ -2517,7 +2517,10 @@ static int __init specialix_init(void)
 			sx_board[i].flags |= SX_BOARD_IS_PCI;
 			if (!sx_probe(&sx_board[i]))
 				found ++;
+
 		}
+		if (i >= SX_NBOARD)
+			pci_dev_put(pdev);

should be converted to PCI probing, rather than this.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
    • From: Jiri Slaby <[email protected]>

• References:
  • [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
    • From: Jiri Slaby <[email protected]>

• Prev by Date: Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h)
• Next by Date: Re: [PATCH 4/10] drivers/char: pci_find_device remove (drivers/char/rocket.c)
• Previous by thread: Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
• Next by thread: Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]