Re: [PATCH] cpuset semaphore depth check deadlock fix

On Fri, 9 Sep 2005, Paul Jackson wrote:
>
> This patch fixes this deadlock by wrapping the up() and down()
> calls on cpuset_sem in kernel/cpuset.c with code that tracks
> the nesting depth of the current task on that semaphore,

We _really_ don't want to have function names like "cs_up()" and
"cs_down()".

Please either call them something half-way readable, like "cpuset_lock()"  
and "cpuset_unlock()". Yes, it's a local static function, but still.. No 
need to be cryptic about it.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] cpuset semaphore depth check deadlock fix
    • From: Paul Jackson <[email protected]>

• References:
  • [PATCH] cpuset semaphore depth check deadlock fix
    • From: Paul Jackson <[email protected]>

• Prev by Date: [PATCH]: Fix buffer overrun in rpadlpar_sysfs.c
• Next by Date: Re: [PATCH] via82cxxx IDE: Support multiple controllers
• Previous by thread: [PATCH] cpuset semaphore depth check deadlock fix
• Next by thread: Re: [PATCH] cpuset semaphore depth check deadlock fix
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]