Re: [PATCH] fix i386 interrupt re-enabling in die() (attempt 2)

Hello Jan,

On Fri, 9 Sep 2005, Jan Beulich wrote:

> -		spin_lock_irq(&die.lock);
> +		spin_lock_irqsave(&die.lock, flags);
>  		die.lock_owner = smp_processor_id();
>  		die.lock_owner_depth = 0;
>  		bust_spinlocks(1);
>  	}
> +	else
> +		local_save_flags(flags);

Just one tiny nit, that else should be on the same line as the curly 
brace.

Thanks
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fix i386 interrupt re-enabling in die()
    • From: "Jan Beulich" <[email protected]>
  • Re: [PATCH] fix i386 interrupt re-enabling in die()
    • From: Zwane Mwaikambo <[email protected]>
  • Re: [PATCH] fix i386 interrupt re-enabling in die() (attempt 2)
    • From: "Jan Beulich" <[email protected]>

• Prev by Date: [PATCH] basic iomem annotations (ppc64)
• Next by Date: [PATCH] bogus cast in bio.c
• Previous by thread: Re: [PATCH] fix i386 interrupt re-enabling in die() (attempt 2)
• Next by thread: [PATCH 2.6.13] ide: ide-dma.c should always check hwif->cds before hwif->cds->foo
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]