Re: Serial maintainership

[Linus Torvalds <torvalds@osdl.org>]

On Thu, 8 Sep 2005, David S. Miller wrote:
> 
> Ok, I'll revert the patch and fix the sunsab.c driver as
> Russell indicated.  So much for type checking...

Actually, I think there's a simpler fix. Instead of reverting, how about 
something like this?

(You might even remove the #ifdef inside the function by then, since "ch" 
being a constant zero will make 90% of it go away anyway).

rmk? Davem?

		Linus

---
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -401,6 +401,9 @@ uart_handle_sysrq_char(struct uart_port 
 #endif
 	return 0;
 }
+#ifndef SUPPORT_SYSRQ
+#define uart_handle_sysrq_char(port,ch,regs) uart_handle_sysrq_char(port, 0, NULL)
+#endif
 
 /*
  * We do the SysRQ and SAK checking like this...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/