Re: [-mm patch 3/5] SharpSL: Abstract c7x0 specifics from Corgi Touchscreen driver

[Richard Purdie <rpurdie@rpsys.net>]

On Thu, 2005-09-08 at 13:10 +0100, Russell King wrote: 
> On Tue, Sep 06, 2005 at 12:53:50PM +0100, Richard Purdie wrote:
> > Separate out the Sharp Zaurus c7x0 series specific code from the Corgi
> > Touchscreen driver. Use the new functions in corgi_lcd.c via sharpsl.h
> > for hsync handling and pass the IRQ as a platform device resource. Move
> > a function prototype into the w100fb header file where it belongs.
> 
> This patch looks a little confused.
> 
> > +	corgi_ts->irq_gpio = platform_get_irq(pdev, 0);
> 
> So irq_gpio is an IRQ number.
> 
> > @@ -313,14 +324,14 @@
> >  	input_register_device(&corgi_ts->input);
> >  	corgi_ts->power_mode = PWR_MODE_ACTIVE;
> >  
> > -	if (request_irq(CORGI_IRQ_GPIO_TP_INT, ts_interrupt, SA_INTERRUPT, "ts", corgi_ts)) {
> > +	if (request_irq(IRQ_GPIO(corgi_ts->irq_gpio), ts_interrupt, SA_INTERRUPT, "ts", corgi_ts)) {
> 
> Or is it.  It _should_ be an IRQ number.

This is a problem because of this code:

if ((GPLR(corgi_ts->irq_gpio) & GPIO_bit(corgi_ts->irq_gpio)) == 0) {

which needs the GPIO number. Perhaps we need to add a IRQ_TO_GPIO define
in pxa-regs.h to deal with this? Would that be acceptable?

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/