Re: [PATCH] Wistron laptop button driver

[Miloslav Trmac <mitr@volny.cz>]

Pekka Enberg wrote:
> On 9/7/05, Miloslav Trmac <mitr@volny.cz> wrote:
> 
>>+static int __init map_bios(void)
>>+{
>>+     static const unsigned char __initdata signature[]
>>+             = { 0x42, 0x21, 0x55, 0x30 };
>>+
>>+     void __iomem *base;
>>+     size_t offset;
>>+     uint32_t entry_point;
>>+
>>+     base = ioremap(0xF0000, 0x10000); /* Can't fail */
> 
> How come? ioremap can return NULL if, for example, we run out of memory.
Not with these values:
> 	/*
> 	 * Don't remap the low PCI/ISA area, it's always mapped..
> 	 */
> 	if (phys_addr >= ISA_START_ADDRESS && last_addr < ISA_END_ADDRESS)
> 		return (void __iomem *) phys_to_virt(phys_addr);

	Mirek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/