Re: [SCSI] qla1280: endianess annotations

[Jeff Garzik <jgarzik@pobox.com>]

Linux Kernel Mailing List wrote:
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -1546,7 +1546,7 @@ qla1280_return_status(struct response * 
>  	int host_status = DID_ERROR;
>  	uint16_t comp_status = le16_to_cpu(sts->comp_status);
>  	uint16_t state_flags = le16_to_cpu(sts->state_flags);
> -	uint16_t residual_length = le16_to_cpu(sts->residual_length);
> +	uint16_t residual_length = le32_to_cpu(sts->residual_length);
>  	uint16_t scsi_status = le16_to_cpu(sts->scsi_status);
[...]
> +	__le16 status_flags;	/* Status flags. */
> +	__le16 time;		/* Time. */
> +	__le16 req_sense_length;/* Request sense data length. */
> +	__le32 residual_length;	/* Residual transfer length. */
> +	__le16 reserved[4];
>  	uint8_t req_sense_data[32];	/* Request sense data. */

This isn't merely an endian annotation.

Is this a size fix, from 16 to 32, or a typo?  If its not a typo, 
shouldn't the variable be declared 'uint32_t residual_length'?

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/