Re: [patch 09/14] x86_64: Don't call enforce_max_cpus when hotplug is enabled

[Ashok Raj <ashok.raj@intel.com>]

On Wed, Sep 07, 2005 at 08:49:50AM +0200, Andi Kleen wrote:
> > 
> > You had suggested in that discussion that it would be better to add an 
> > option for startup. Iam opposed to adding any option, when we certainly know 
> 
> I suggested to auto detect it based on ACPI information. I don't 
> think I ever wrote anything about an option.
> 
> If that is not possible it's better to always use the sequence mechanism.

Using ACPI or any other method to choose broadcast or use mask version
of IPI in flat mode for <=8 cpus has no real value. I had posted a 
small stat program that showed using mask IPI provides same performance numbers.

We didnt choose that method only because there is no perf gain except code 
bloat. I dont understand putting all that complexity without any real merrit.

Moreover CONFIG_HOTPLUG_CPU does not imply physical CPU hotplug, which i had
tried to convey several times. 

It is important to understand that there is no just ONE RIGHT way
and that we consider alternatives for the right reason.

> 
> 
> P.S.: Don't bother sending me such "blame game" mails again. I will
> just d them next time because they're a waste of time.

Sorry Andi if you felt that way. I was trying to get some consistent feedback
and that you also consider and weight in what we explain instead of being
a one way street.

Certainly my intend was not to blame you, but to explain with clarity
so we dont end up reworking some trivial patches for a long time.

If you feel that way, i deeply apologize, and repeat, thats not my intend.
> 

-- 
Cheers,
Ashok Raj
- Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/