On 9/6/05, Lee Revell <[email protected]> wrote:
> On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
> > Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
> > Intel 82855PM chipset.
>
> > + } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {
>
> Should unlikely() be used for cases where the conditional will be true
> iff a specific piece of hardware is present? Seems like we'd always
> lose.
>
I would say that we should definitely not use [un]likely for code that
is executed once during boot.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |