Re: [PATCH] ipw2200: Missing kmalloc check

[Jiri Slaby <jirislaby@gmail.com>]

Panagiotis Issaris napsal(a):

> The ipw2200 driver code in current GIT contains a kmalloc() followed by
> a memset() without handling a possible memory allocation failure.
>
> Signed-off-by: Panagiotis Issaris <panagiotis.issaris@gmail.com>
> ---
>
> drivers/net/wireless/ipw2200.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> 8e288419b49346fee512739acac446c951727d04
> diff --git a/drivers/net/wireless/ipw2200.c
> b/drivers/net/wireless/ipw2200.c
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -3976,6 +3976,10 @@ static struct ipw_rx_queue *ipw_rx_queue
> 	int i;
>
> 	rxq = (struct ipw_rx_queue *)kmalloc(sizeof(*rxq), GFP_KERNEL);
> +	if (unlikely(!rxq)) {
> +		IPW_ERROR("memory allocation failed\n");
> +		return NULL;
> +	}
> 	memset(rxq, 0, sizeof(*rxq));
>  
and use kzalloc instead of kmalloc and memset 0?

> 	spin_lock_init(&rxq->lock);
> 	INIT_LIST_HEAD(&rxq->rx_free);
>  
--
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@gmail.com      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/