Re: [PATCH] custom PM support for 8250

[Grigory Tolstolytkin <gtolstolytkin@dev.rtsoft.ru>]

Hi Russel,

I tried the patch provided by Vitaly Wool. And it works correctly. And 
now I'm successful with the PM support for my own serial8250 driver. Are 
you planning to commit the Vitlaly's changes into the mainstream? I 
guess it'll be helpful for the other people too. What I want is to know 
whether this changes will be supported by the Community or not. It's 
important for the project I'm worin on, cause I'm planning to push it 
into Open Source ;)

Thanks,
Grigory.

Russell King wrote:

> On Wed, Aug 31, 2005 at 03:10:09PM +0400, Vitaly Wool wrote:
>  
>
> > please find the patch that allows passing the pointer to custom power 
> > management routine (via platform_device) to 8250 serial driver.
> > Please note that the interface to the outer world (i. e. exported 
> > functions) remained the same.
> >    
>
> I'd rather change the structure passed via the platform device to
> something like:
>
> struct platform_serial_data {
> 	void	(*pm)(struct uart_port *port, unsigned int state, unsigned int old);
> 	int	nr_ports;
> 	struct plat_serial8250_port *ports;
> };
>
> which also eliminates the empty plat_serial8250_port terminator from
> all the serial8250 platform devices (which appears to have caused some
> folk problems.)
>
> It does mean that a set of 8250 ports (grouped by each platform device)
> have a common power management method - which seems a logical restriction.
>
>  

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/