Re: [DVB patch 51/54] ttpci: av7110: RC5+ remote control support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 04, 2005 Nish Aravamudan wrote:
> On 9/4/05, Johannes Stezenbach <[email protected]> wrote:
> > --- linux-2.6.13-git4.orig/drivers/media/dvb/ttpci/av7110_ir.c  2005-09-04 22:03:40.000000000 +0200
> > +++ linux-2.6.13-git4/drivers/media/dvb/ttpci/av7110_ir.c       2005-09-04 22:31:00.000000000 +0200
> > @@ -7,16 +7,16 @@
> >  #include <asm/bitops.h>
> > 
> >  #include "av7110.h"
> > +#include "av7110_hw.h"
> > 
> > -#define UP_TIMEOUT (HZ/4)
> > +#define UP_TIMEOUT (HZ*7/25)
> 
> Should this be
> 
> #define UP_TIMEOUT msecs_to_jiffies(280)
> 
> or
> 
> #define UP_TIMEOUT (7*msecs_to_jiffies(40)
> 
> ?

I agree it's nicer to read, but AFAIK not required for correctness?
If so, then we'll fix those up in linuxtv.org CVS and submit
cleanup patches later.

Thanks for your comments.

Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux