Trond Myklebust <[email protected]> wrote:
>
> to den 01.09.2005 Klokka 20:45 (-0700) skreiv Andrew Morton:
> > Trond Myklebust <[email protected]> wrote:
> > >
> > > +static inline int do_posix_truncate(struct dentry *dentry, loff_t length)
> > > +{
> > > + /* In SuS/Posix lore, truncate to the current file size is a no-op */
> > > + if (length == i_size_read(dentry->d_inode))
> > > + return 0;
> > > + return do_truncate(dentry, length);
> > > +}
> >
> > We have the same optimisation in inode_setattr()...
>
> Look again. The two are NOT the same.
>
> The code in inode_setattr() will cause truncate() to erroneously update
> the ctime/mtime.
Of course. But with your patch, the optimisation in inode_setattr() is
redundant (except for O_TRUNC, perhaps).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |