Andrew Morton wrote:
Ok, that's probably better, and this probably belongs in /proc/sys/dev/ipmi. This is new enough that it doesn't matter, I don't think any one is using it yet.Corey Minyard <minyard@acm.org> wrote:Indeed, this function is badly written. In rewriting, I couldn't find a nice function for reading integers from userspace, and the proc_dointvec stuff didn't seem terribly suitable.We write numbers into profs files all the time. Is there something different about the IPMI requirement which makes the approach used by, say, dirty_writeback_centisecs_handler() inappropriate?
Patch is attached. -Corey
Attachment:
ipmi-poweroff-fix-chassis-ctrl.patch
Description: unknown/unknown
- References:
- [RFC][CFLART] ipmi procfs bogosity
- From: viro@ZenIV.linux.org.uk
- Re: [RFC][CFLART] ipmi procfs bogosity
- From: Corey Minyard <minyard@acm.org>
- Re: [RFC][CFLART] ipmi procfs bogosity
- From: Andrew Morton <akpm@osdl.org>
- [RFC][CFLART] ipmi procfs bogosity
- Prev by Date: [PATCH][RFC] Ext3 online resizing locking issue (Again)
- Next by Date: [PATCH]kprobes comment patch around kprobes lock functions
- Previous by thread: Re: [RFC][CFLART] ipmi procfs bogosity
- Next by thread: where can I get ext3 patch for linux-2.4.1
- Index(es):
